Skip to content

[react] Add types for experimental_useEvent#62354

Merged
eps1lon merged 1 commit into
DefinitelyTyped:masterfrom
std4453:feat/react/experimental-use-event
Sep 22, 2022
Merged

[react] Add types for experimental_useEvent#62354
eps1lon merged 1 commit into
DefinitelyTyped:masterfrom
std4453:feat/react/experimental-use-event

Conversation

@std4453

@std4453 std4453 commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes:
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot

typescript-bot commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

@std4453 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 62354,
  "author": "std4453",
  "headCommitOid": "02ba1bf925d6f6a032ed0bef03051193a5bc872a",
  "mergeBaseOid": "92c5bb54fd93480513739ae26a62ad7fa36279e2",
  "lastPushDate": "2022-09-22T04:36:46.000Z",
  "lastActivityDate": "2022-09-22T04:36:46.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/experimental.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/test/hooks.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan",
        "priyanshurav"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "eps1lon",
      "date": "2022-09-21T18:57:55.000Z",
      "abbrOid": "282da70"
    }
  ],
  "mainBotCommentID": 1253838676,
  "ciResult": "pass"
}

@typescript-bot

Copy link
Copy Markdown
Contributor

@std4453
std4453 force-pushed the feat/react/experimental-use-event branch from 65d9032 to 282da70 Compare September 21, 2022 15:03
@DangerBotOSS

DangerBotOSS commented Sep 21, 2022

Copy link
Copy Markdown

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

react (unpkg)

was missing the following properties:

  1. unstable_act

Generated by 🚫 dangerJS against 02ba1bf

@eps1lon eps1lon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but should be consistent with useCallback

Comment thread types/react/experimental.d.ts Outdated
@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Sep 21, 2022
@typescript-bot

Copy link
Copy Markdown
Contributor

@std4453 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

1 similar comment
@typescript-bot

Copy link
Copy Markdown
Contributor

@std4453 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@std4453
std4453 force-pushed the feat/react/experimental-use-event branch from 282da70 to 63a8e65 Compare September 22, 2022 03:31
@typescript-bot typescript-bot removed the Revision needed This PR needs code changes before it can be merged. label Sep 22, 2022
@std4453
std4453 requested review from eps1lon and removed request for Jessidhia and johnnyreilly September 22, 2022 03:32
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Sep 22, 2022
@typescript-bot

Copy link
Copy Markdown
Contributor

@std4453 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@std4453
std4453 force-pushed the feat/react/experimental-use-event branch from 63a8e65 to 02ba1bf Compare September 22, 2022 04:36
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Sep 22, 2022
@typescript-bot

Copy link
Copy Markdown
Contributor

@eps1lon Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@eps1lon eps1lon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eps1lon
eps1lon merged commit 02e14f0 into DefinitelyTyped:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants