[react] Add types for experimental_useEvent#62354
Conversation
|
@std4453 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 62354,
"author": "std4453",
"headCommitOid": "02ba1bf925d6f6a032ed0bef03051193a5bc872a",
"mergeBaseOid": "92c5bb54fd93480513739ae26a62ad7fa36279e2",
"lastPushDate": "2022-09-22T04:36:46.000Z",
"lastActivityDate": "2022-09-22T04:36:46.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react/test/hooks.tsx",
"kind": "test"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "eps1lon",
"date": "2022-09-21T18:57:55.000Z",
"abbrOid": "282da70"
}
],
"mainBotCommentID": 1253838676,
"ciResult": "pass"
} |
|
🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav — please review this PR in the next few days. Be sure to explicitly select |
65d9032 to
282da70
Compare
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. react (unpkg)was missing the following properties:
|
eps1lon
left a comment
There was a problem hiding this comment.
Looks great but should be consistent with useCallback
|
@std4453 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
1 similar comment
|
@std4453 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
282da70 to
63a8e65
Compare
|
@std4453 The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
- [`experimental_useEvent` entrypoint](https://unpkg.com/browse/react@0.0.0-experimental-3d615fc14-20220919/cjs/react.development.js) - [implementation](https://unpkg.com/browse/react-dom@0.0.0-experimental-3d615fc14-20220919/cjs/react-dom.development.js) - [experimental_useEvent](react/react#25229)
63a8e65 to
02ba1bf
Compare
|
@eps1lon Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition: