[29.x] Backports#33474
Merged
Merged
Conversation
The next commit requires an additional mainnet block which changes the difficulty. Also fix a few minor mistakes in the test (suite): - rename the create_coinbase retarger_period argument to halving_period. Before bitcoin#31583 this was hardcoded for regtest where these values are the same. - drop unused fees argument from mine helper Finally the CPU miner instructions for generating the alternative mainnet chain are expanded. Github-Pull: bitcoin#33446 Rebased-From: 4c3c1f4
A target field was added to the getblock and getblockheader RPC calls in bitcoin#31583, but it mistakingly always used the tip value. Because regtest does not have difficulty adjustment, a test is added for mainnet instead. Github-Pull: bitcoin#33446 Rebased-From: bf7996c
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33474. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Github-Pull: bitcoin#33484 Rebased-From: ff05beb
Using bypass_limits=true is essentially fuzzing part of a reorg only, and results in TRUC invariants unable to be checked. Remove most instances of bypassing limits, leaving one harness able to do so. Github-Pull: bitcoin#33504 Rebased-From: bbe8e90
Not enforcing TRUC topology on reorg was the intended behavior, but the appropriate bypass argument was not checked. This mistake means we could potentially invalidate a long chain of perfectly incentive-compatible transactions that were made historically, including subsequent non-TRUC transactions, all of which may have been very high feerate. Lastly, it wastes CPU cycles doing topology checks since this behavior cannot actually enforce the topology in general for the reorg setting. Github-Pull: bitcoin#33504 Rebased-From: 26e71c2
Github-Pull: bitcoin#33504 Rebased-From: 06df14b
dergoegge
approved these changes
Oct 2, 2025
Member
|
ACK 2d7ebd2 |
glozow
added a commit
that referenced
this pull request
Oct 3, 2025
d82fc69 doc: update release notes for 29.2rc2 (fanquake) 513cef7 doc: update manual pages for v29.2rc2 (fanquake) eea16f7 build: bump version to v29.2rc2 (fanquake) 6b3c1db contrib: fix using macdploy script without translations. (amisha) Pull request description: It's been 2 weeks since rc1: https://github.com/bitcoin/bitcoin/releases/tag/v29.2rc1. We've backported more changes: * #33403 * #33474 * #33482 Lets do `rc2`. ACKs for top commit: davidgumberg: reACK d82fc69 glozow: ACK d82fc69 darosior: utACK d82fc69. Changes look good to me, but i have not been through the process of regenerating the doc myself. Tree-SHA512: c829efe89f86c9c76767ffe60a3779ece902ee9e3c8f6b4203562aaf257019484bfa49916ddfabdcabbd1478368d9b80a3f0a15057778aa1984852ea245283a6
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
e3820d4 doc: update release notes for 29.x (fanquake) 69c4661 test: add more TRUC reorg coverge (Greg Sanders) e439ed1 Mempool: Do not enforce TRUC checks on reorg (Greg Sanders) 54377c7 fuzz: don't bypass_limits for most mempool harnesses (Greg Sanders) cf82bb4 doc: rpc: fix case typo in `finalizepsbt` help (final_scriptwitness) (Sebastian Falbesoner) ff55cf5 rpc: fix getblock(header) returns target for tip (Sjors Provoost) b29bbb0 test: add block 2016 to mock mainnet (Sjors Provoost) Pull request description: Backports: * bitcoin#33446 * bitcoin#33484 * bitcoin#33504 ACKs for top commit: luke-jr: ACK e3820d4 dergoegge: ACK e3820d4 marcofleon: ACK e3820d4 Tree-SHA512: 27b852177d8502d6c703cb0eeb1e4df9d651c9c8add5fbf6ae4eeb4b8aefc145471f38f9794c0ed276bf7ebba1844ecbaf5a84cb5913ca7d0a546f5216ea3b2d
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
a735fe5 doc: update release notes for 29.2rc2 (fanquake) 69cd3ef doc: update manual pages for v29.2rc2 (fanquake) f7f8689 build: bump version to v29.2rc2 (fanquake) ed62c32 contrib: fix using macdploy script without translations. (amisha) Pull request description: It's been 2 weeks since rc1: https://github.com/bitcoin/bitcoin/releases/tag/v29.2rc1. We've backported more changes: * bitcoin#33403 * bitcoin#33474 * bitcoin#33482 Lets do `rc2`. ACKs for top commit: davidgumberg: reACK a735fe5 glozow: ACK a735fe5 darosior: utACK a735fe5. Changes look good to me, but i have not been through the process of regenerating the doc myself. Tree-SHA512: c829efe89f86c9c76767ffe60a3779ece902ee9e3c8f6b4203562aaf257019484bfa49916ddfabdcabbd1478368d9b80a3f0a15057778aa1984852ea245283a6
ivanlele
added a commit
to ivanlele/elements
that referenced
this pull request
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports:
finalizepsbthelp (final_scriptwitness) #33484