[30.x] More backports#34283
Merged
Merged
Conversation
Github-Pull: bitcoin#34252 Rebased-From: 44b12cd
The previous `assert` used `>=`, allowing `input_index == psbt.inputs.size()` and out-of-bounds access in `psbt.inputs[input_index]`. Found during review: bitcoin#31650 (comment) Github-Pull: bitcoin#34272 Rebased-From: 2f5b1c5
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34283. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
This was referenced Jan 14, 2026
Github-Pull: bitcoin#34185 Rebased-From: 9b57c8d
Github-Pull: bitcoin#34185 Rebased-From: 8fb5e5f
09cf8be to
0b11d7a
Compare
The regex `(.*)` was capturing `\r` from subprocess output on Windows, causing the closing parenthesis in logs to wrap to the next line. Stripping whitespace from the regex match fixes the formatting. Github-Pull: bitcoin#34282 Rebased-From: 979d41b
0b11d7a to
d2ecf8c
Compare
Github-Pull: bitcoin#34344 Rebased-From: 9482f00
d2ecf8c to
12e75fc
Compare
Facilitate use on distros that might have 'tar' as something else, such as 'gtar', i.e Chimera. Github-Pull: bitcoin#34390 Rebased-From: be2b48b
12e75fc to
6ab1db8
Compare
Github-Pull: bitcoin#34281 Rebased-From: fa37928
6ab1db8 to
725e6ee
Compare
This was referenced Jan 27, 2026
added 2 commits
January 28, 2026 14:24
The section claims to be for ccache builds, however those are already fixed after commit 1cc58d3. If there are still any build or debug problems after that commit, dedicated instructions can be added back, along with exact steps to reproduce and test. Github-Pull: bitcoin#34413 Rebased-From: fa06cd4
The -ffile-prefix-map option is no longer used and it seems fine to remove the warning about it possibly breaking coverage builds. If this needs documentation, the dev notes seem like a better place, because it also affects other places, such as depends. C.f. commit 407062f Github-Pull: bitcoin#34413 Rebased-From: fa2e1b8
725e6ee to
8dbdec1
Compare
removeprunedfunds removes all entries from mapTxSpends for the inputs of the pruned tx. However, this is incorrect, because there could be multiple entries from conflicting transactions (that shouldn't be removed as well). This could lead to the wallet creating invalid transactions, trying to double spend utxos. The bug persists when the conflicting tx was mined, because the wallet trusts its internal accounting instead of calling AddToSpends again. Github-Pull: bitcoin#34358 Rebased-From: 1f60ca3
8dbdec1 to
836adc0
Compare
We can use vswhere.exe directly to create a vs developer prompt and so can remove this third party dependency. Co-authored-by: David Gumberg <davidzgumberg@gmail.com> Github-Pull: bitcoin#32513 Rebased-From: 7ae0497
This sets up a vs developer command prompt and should hopefully should be more resilient to upstream changes Co-authored-by: David Gumberg <davidzgumberg@gmail.com> Github-Pull: bitcoin#32513 Rebased-From: e1a1b14
The other executables have manifests and these should be checked in addition to bitcoind. Skipping fuzz.exe, bench_bitcoin.exe and test_bitcoin-qt.exe as they do not have manifests. Github-Pull: bitcoin#32513 Rebased-From: 1569279
836adc0 to
624c745
Compare
willcl-ark
approved these changes
Jan 29, 2026
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
5516cdf doc: update release notes for v30.x (fanquake) ed0f9d9 ci: Check windows manifests for all executables (Max Edwards) 1ea51a4 ci: use a more generic way of finding mt.exe (Max Edwards) 4ef0eb9 ci: remove 3rd party js from windows dll gha job (Max Edwards) 7d298bf wallet: fix removeprunedfunds bug with conflicting transactions (Martin Zumsande) f4957df build: Remove outdated comment about -ffile-prefix-map (MarcoFalke) 2d36935 doc: Remove outdated -fdebug-prefix-map section in dev notes (MarcoFalke) a9ff62b build: Temporarily remove confusing and brittle -fdebug-prefix-map (MarcoFalke) d529f01 test: allow overriding tar in get_previous_releases (fanquake) 72272fe chore: Update outdated GitHub Actions versions (Padraic Slattery) 500618b qa: Fix Windows logging bug (Hennadii Stepanov) 397a371 test: check wallet rescan properly in feature_pruning (brunoerg) c2fbc8c test: fix feature_pruning when built without wallet (brunoerg) 74f9b2c psbt: Fix `PSBTInputSignedAndVerified` bounds `assert` (Lőrinc) 7995038 doc: add 433 (Pay to Anchor) to bips.md (Sebastian Falbesoner) Pull request description: Backports: * bitcoin#32513 * bitcoin#34185 * bitcoin#34272 * bitcoin#34252 * bitcoin#34281 * bitcoin#34282 * bitcoin#34344 * bitcoin#34358 * bitcoin#34390 * bitcoin#34413 ACKs for top commit: willcl-ark: ACK 5516cdf marcofleon: ACK 5516cdf Tree-SHA512: 65f413419b50784d2661d89f2044acd5196eacd50841bb93d7437b83bd23ce535565168cd4c53f96ba485863a911f5a1ea5476b22955d6b931b65e87f78b9a17
Merged
sedited
added a commit
that referenced
this pull request
Jun 23, 2026
d52747d doc: update manual pages for v30.3rc1 (fanquake) a1406d6 build: bump version to v30.3rc1 (fanquake) 1bdd2b1 doc: update release notes for v30.3rc1 (fanquake) e7c6d39 fuzz: Remove unused g_setup pointers (MarcoFalke) b7c7d1e coins: compact chainstate in background (Lőrinc) 992b1dd validation: randomly compact chainstate (Lőrinc) 55ead70 coins: test chainstate flush baseline (Lőrinc) d09bd0f lint: disable leveldb subtree check (fanquake) Pull request description: Backports: * #34918 * #35465 Final changes for v`30.3rc1`. Backports since `30.2`: * #34283 * #34459 * #34689 * #34754 * #34805 * #34856 * #35211 * #35232 ACKs for top commit: sedited: ACK d52747d marcofleon: ACK d52747d Tree-SHA512: 75fb64f744a0689a9bc4f5a25128bf2aaad7459d7a430f552200b995498428d89de28820f477780f95e7e8485eea9f657ad5fdeae253940df4f29bf51346b4ff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports:
feature_pruningwhen built without wallet #34185PSBTInputSignedAndVerifiedboundsassert#34272-fdebug-prefix-map#34281taringet_previous_releases.py#34390