[30.x] validation: correct lifetime of precomputed tx data#35211
Merged
Conversation
This makes sure `txsdata` always outlives the Script check queue (since local objects are destructed in reverse order of construction). This is the root cause for a security vulnerability reported by Cory Fields in 2024 that could be exploited by crafting an invalid block to cause nodes to read freed memory. The vulnerability was covertly fixed in commit `492e1f09943fcb6145c21d470299305a19e17d8b`. See security advisory for CVE-2024-52911 for more details. Github-Pull: bitcoin#35209 Rebased-From: 1ed799f
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35211. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
Member
|
ACK 17de6d2 |
Merged
sedited
added a commit
that referenced
this pull request
Jun 23, 2026
d52747d doc: update manual pages for v30.3rc1 (fanquake) a1406d6 build: bump version to v30.3rc1 (fanquake) 1bdd2b1 doc: update release notes for v30.3rc1 (fanquake) e7c6d39 fuzz: Remove unused g_setup pointers (MarcoFalke) b7c7d1e coins: compact chainstate in background (Lőrinc) 992b1dd validation: randomly compact chainstate (Lőrinc) 55ead70 coins: test chainstate flush baseline (Lőrinc) d09bd0f lint: disable leveldb subtree check (fanquake) Pull request description: Backports: * #34918 * #35465 Final changes for v`30.3rc1`. Backports since `30.2`: * #34283 * #34459 * #34689 * #34754 * #34805 * #34856 * #35211 * #35232 ACKs for top commit: sedited: ACK d52747d marcofleon: ACK d52747d Tree-SHA512: 75fb64f744a0689a9bc4f5a25128bf2aaad7459d7a430f552200b995498428d89de28820f477780f95e7e8485eea9f657ad5fdeae253940df4f29bf51346b4ff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #35209 to the version 30 branch.