refactor: use cargo-make's built-in arg expansion instead of custom plugin support in nested-cargo-workspace-in-cargo-make-emulated-workspace-support#201
Merged
Conversation
wmmc88
commented
Aug 26, 2024
…_runner_args" This reverts commit 2d199bc.
42b0e39 to
a495685
Compare
ayodejiige
approved these changes
Aug 30, 2024
hamzamust
approved these changes
Aug 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom env var expansion was added to
nested-cargo-workspace-in-cargo-make-emulated-workspace-supportsince cargo-make didn't support it. Now that sagiegurari/cargo-make#1132 has merged support for this incargo-makeitself, there is no longer a need to do this manually in the plugin.This reverts commit 2d199bc.
fixes #194